Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #301

Merged
merged 1 commit into from
Sep 10, 2023
Merged

fix typo #301

merged 1 commit into from
Sep 10, 2023

Conversation

AlexHls
Copy link
Collaborator

@AlexHls AlexHls commented Sep 8, 2023 •
edited
Loading

PR Summary

Fixes a small typo in the regula_falsi root find routine.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

@AlexHls AlexHls requested a review from jonahm-LANL September 8, 2023 14:40
@AlexHls AlexHls marked this pull request as ready for review September 8, 2023 14:40
Yurlungur
Yurlungur approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Yurlungur Yurlungur merged commit cf88624 into main Sep 10, 2023
@Yurlungur Yurlungur deleted the hls/rootfind-typo-fix branch September 10, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@jonahm-LANL jonahm-LANL Awaiting requested review from jonahm-LANL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexHls @Yurlungur